Submitted over 2 years ago

Interactive rating using (ReactJS + TS), RTL, CSS Modules

react, react-testing-library, typescript

Ken•40

@cyyong95

A solution to the Interactive rating component challenge

Preview Code

Solution retrospective

It's quite interesting to build this project using React. I've got to learn about testing using RTL, which was quite fun.

The only thing I'm still trying to figure out is when to use REM and EM. Currently I use REM more often since it seems to make more sense for all the elements to scale the same size instead of some elements scaling differently due to font size of the parent when using EM.

Code

Please log in to post a comment

Community feedback

Adriano•42,890
@AdrianoEscarabote
Posted over 2 years ago
Hi Ken, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

2- We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

Example:

native HTML5 reference elements:
```
<body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>
```
ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
```
<body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>
```
It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

Link to read more about: click here

2- Why it Matters

Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

Rule Description

It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

Link to read more about: click here

Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

The rest is great!!

Hope it helps...👍

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord