Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive-card-form

FreeManβ€’ 50

@Erick-86

Desktop design screenshot for the Interactive card details form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Making the number, date and pin inputs alert users that wrong format, numbers. Couldn't do it for all but managed to do for the number input with the help of ChatGPT

Community feedback

Abdul Khalid πŸš€β€’ 72,160

@0xabdulkhalid

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution had generated accessibility error report due to lack of level-one heading <h1>
  • Every site must want at least one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

JAVASCRIPT 🟑:

  • The way you declared variables are need to be well structured and organized
  • Take a look at the following example code which describes an efficient way of declaring variables
const firstName = "Your";
const lastName = "Name";
const emailAddress = "[email protected]";
const password = "supersecret";
  • instead try this,
const firstName =  "Your",
       lastName =  "Name",
       emailAddress = "[email protected]"
       β€’β€’β€’                
       β€’β€’β€’         // n number of declarations
       password = "supersecret";   // make sure to add a semicolon at end of last declaration
  • This single line declaration with separated commas will helps you to have a better structured code and improves readability though

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

FreeManβ€’ 50

@Erick-86

Posted

@0xAbdulKhalid thank you, i understand the JavaScript side but with the html, I'm a little bit confused. I will be very grateful if you explain it further to me please. Thank you once again

0
Finneyβ€’ 3,030

@Finney06

Posted

Hello FreeManπŸ‘‹. Good job on completing the challenge !

Here's a suggestion regarding your code that may be of interest to you.

HTML 🏷️:

To clear the Accessibility report:

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy.

I hope you find it helpful!😏 Above all, the solution you submitted is πŸ‘Œ. πŸŽ‰Happy coding!

Marked as helpful

0

FreeManβ€’ 50

@Erick-86

Posted

@Finney06 Thank you for this guide, i really appreciate

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord