Abdul Khalid 🚀• 71,860
@0xabdulkhalid
Posted
Salaam Alaikum 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>typically contains information about the author of the section, copyright data or links to related documents.
- The
- So resolve the issue by wrapping the both component states (
.rate-container&.thank-you) using the proper semantic element<main>along with<div class="attribution">into a<footer>element in yourindex.htmlfile to improve accessibility and organization of your page
- So the resulted markup would be like this,
<body>
<main>
<!-- Rating state start -->
<div class="rate-container"></div>
<!-- Rating state end -->
<!-- Thank you state start -->
<div class="thank-you"></div>
<!-- Thank you state end -->
</main>
<footer class="attribution"></footer>
</body>
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1
Mahbub Hossen• 20
@mhbabu2002
Posted
Thank you very much for your valuable comments. @0xabdulkhalid
0
Abdul Khalid 🚀• 71,860
@0xabdulkhalid
Posted
@mhbabu2002 Glad you found it helpful ! 🤠
1
