Mpho Mamphoke• 10
@Sayfo1809
Posted
I realised, while going through your js code that you left your tests in there.
0
Looking to hire developers?
No particular question but any recommendations to improve is welcome :D
@Sayfo1809
Posted
I realised, while going through your js code that you left your tests in there.
@GrzywN
Posted
Awesome job on the challenge!
I have some minor suggestions regarding your solution:
orange
and other ones start with uppercase and use PascalCase. I would recommend using kebab-case, but of course it's up to you what you prefer. Also it's good to remain consistent in using class names. For example you can name every element with a class and use classes instead of combining classes with children selectors. These are really small, but it's great when code is readable, consistent and maintainable, even if newer editors like VS Code have autocompletion.*
. I think the only moment when you can use this selector is at the beginning, when you reset/normalize things e.g. margins, paddings and setting box-sizing: border-box
. Also sometimes when some script is working on every element on the page (e.g. animation stopper).vertical-align
property which doesn't work in this case, since it only works for tables and inline elements. To center a div, you can use properties: display: grid
and place-content: center
/ place-items: center
. You can of course use flexbox, but grid is also the way I like and I wanted to recommend.Hope this helps! Have a nice day and happy coding! :)
@ccreusat
Posted
Hi ! Nice challenge done !
You should fix to things :
<label>
numbers (seems to not be centered)Hope this helps & enjoy coding!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord