@vanzasetia
Posted
Hi, Majay! 👋
Congratulations on finishing this challenge! 👏
The hardest part of this challenge for me was when I created the Regular Expression for the validations. 😅 How about you?
Anyway, here is some feedback from me.
- The alert message for the first name input says, "Must be made of alphabets, not contain numbers and contain 5-12 characters". But, when I only input two characters, it is a valid input. The same goes for the last name input.
- For the
error-image, I recommend making it a background image instead of theinputelement. This way, you can clean up the HTML a little bit. inputwithtype="submit"was used before thebuttonelement exist. It's best to avoid using legacy elements. So, I recommend usingbuttonelement instead.
I notice that main.css is minified. It makes me harder to give feedback to your CSS because I have to open the Sass files one by one. So, I recommend adding the "non-minified" CSS for people to review.
I hope this helps! Keep up the good work! 👍
Marked as helpful
@jonathan401
Posted
@vanzasetia Thanks for pointing out the error with the first name and last name regex pattern 😄. I had completely forgot to update it while I was still testing validation on the input fields 😅. And for the error-image, I'll try fixing that as soon as I can ☺️. I'll also make sure I fix that submit button up too 😁.
And lastly for the main.css I had used the live sass compiler extension in Vs code, not really sure if I could configure this to not make the main.css file not minified. I'll also be fixing that up too 😄. Thanks so much for your review ☺️
@vanzasetia
Posted
@jonathan401 No problem! 👍
