Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro component with sign up form

Chris• 240

@Chris94Lee

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback would be nice!

I know I need to add the ! to the inputs on error. Plus I need to add the box shadow to the CTAs plus the form container.

I think I also need to add more breakpoints.

Community feedback

Ovidiu-Antonio• 3,125

@ovidiuantonio

Posted

Hello Chris,

Very nice solution! You did a very good job!

I have a few tips that can help you making this solution even better:

  • add a max-width and margin: 0 auto; to the main container, because on a bigger screen the text and the card are not anymore in the center of the page
  • you can add cursor: pointer; to the "Terms and services" too, for a better UX
  • and don't forget to add the shadows to the purple container and the form

Happy coding and keep going!

2

Chris• 240

@Chris94Lee

Posted

@ovidiuantonio Thank you.

I completely forgot to check for bigger screens than 1440. What would the best way to center the main container vertically? As I added in your suggestion with margin and max width, but I'm unsure on the best way to center it vertically. The way I'd usually do this is just set height:100vh. Is this bad practice, or is there a better way to do it?

0
Ovidiu-Antonio• 3,125

@ovidiuantonio

Posted

@twister896 if you want to center it horizontally and vertically at the same time you can use position absolute.

On the body you can add min-height: 100vh; and position: relative; On the mainContainer you can add position: absolute; top: 50%; left: 50%; transform: translate(-50%, -50%);

(and forgot about th max-width and the margins you applied on the mainContainer)

1
El Ghali Khalid• 2,630

@limtedtorni000

Posted

Great job on this challenge i suggest to add (cursor: pointer;) for the button it will make better in my opinion , overall it's fantastic.

2

Chris• 240

@Chris94Lee

Posted

@limtedtorni000 Thank you, I'll add that in now!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord