Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro component with sign up form

Kacper Kwinta 1,405

@kacperkwinta

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Built with 🧱

  • Semantic HTML5 markup
  • CSS
  • JS
  • Grid
  • Custom properties
  • @media
  • ::after
  • @keyframes

Community feedback

Tryt4n 940

@Tryt4n

Posted

It's not exactly semantic HTML because if you have input you should have to also have label for that input even when it's not visible. And then if label wouldn't be visible at the page it should have aria-label describing that label, so it should look like this:

label for="firstName" aria-label="Enter your first name"

input class="input" type="text" name="firstName" placeholder="First Name"

Also for img in semantic HTML important is alt tag so you should write something like alt="error icon"

Also you can you can emphasize text Terms and Services with element em or strong. In this case I think better would be em.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord