Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro Component with Sign Up Form using SCSS, JS, Flexbox and Grid

#sass/scss

@mohamadadithya

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Your feedback is useful for me :).

Community feedback

@UDsGitHub

Posted

Hi Mohamad, Nice work on your site... a few things you could add to make it work better..

  1. min-height: 100vh on your body so that the background wouldnt clip on the bottom.. also if you have background-repeat: no-repeat, remove that too.
  2. You could add padding to your body so that its children wouldnt touch the borders of the screen.
  3. You should make the purple "Try it free 7 days then $20/mo. thereafter" a link (a tag) because it is supposed to be a link.
  4. You could remove the empty form action attribute and other attribute and let them default. Other than that, you should be good my man.. keep it up👍

Marked as helpful

0

@mohamadadithya

Posted

@UDsGitHub Hey, thanks for your feedback/advice, it's help me a lot ;).

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord