Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Intro Component with signup form

Lucas 👾•104,160
@correlucas
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Daniel 🛸•44,740
    @danielmrz-dev
    Posted about 1 year ago

    Fala, Lucas!

    Tenho uma sugestão sobre o Javascript:

    📌 A validação que você usou na função adiciona o ícone de erro caso os inputs estejam vazios, porém você não adicionou uma instrução que remova esse ícone caso o input não esteja mais vazio.

    Então se você tentar enviar com algum dos inputs vazio, ele mostra o ícone, mas se você voltar e preencher o input, o ícone de erro não desaparece.

    📌 Uma outra sugestão seria você fazer aparecer as mensagens de erro junto com o ícone de erro. No seu HTML, o elemento até existe, você colocou display: none nele, então ele não aparece. Você poderia mudar o display pra block usando o javascript dentro da mesma validação que verifica se o input está vazio. Ficaria algo do tipo:

    if (input está vazio) {
        mostre o ícone;
        mostre a mensagem de erro;
    else {
        remova o ícone;
        remova a mensagem de erro;
    }
    

    Assim, tanto o ícone quanto a mensagem aparecem juntos.

    Espero que ajude! Abraço!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub