Community feedback

• 

  Ivan•2,610

  @isprutfromua

  Posted over 3 years ago

  Frontendmentor

  Hi there. You did a good job 😎

  keep improving your programming skills

  your solution looks great, however, if you want to improve it, you can follow these steps:

  • what is the reason of such a connection of styles? these files do not take up much space, but you make 3 requests instead of one, this is extremely important for performance

        <link rel="stylesheet" href="./css/fonts.css" />
          <link rel="stylesheet" href="./css/reset.css" />
          <link rel="stylesheet" href="./css/style.css" />
  

  • it's better to use labels

  
                            <input
                                  type="password"
                                  placeholder="Password"
                                  id="password"
                                  autocomplete="current-password"
                              />
                              <label class="input-group__help" for="password"
                                  >Password cannot be empty</label
                              >
  
  

  • the field may contain a string with space and your check will not work

  // check if input is empty
      if (!element.value) {
          return element.parentElement.classList.add("invalid");
      }
  

  I hope my feedback will be helpful. You can mark it as useful if so 👍

  Good luck and fun coding 🤝⌨️

  01

  Marked as helpful