Intro component with sign-up form

Community feedback

• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Hey, Erik Tangvik! 👋

  Good work on this challenge! Your solution is responsive! 👍

  Other than allowing the background image to fill up the entire area of the screen (as ezraguy so helpfully suggested) I think taking away the error messages on the input elements once the user has entered valid input (rather than after the user hits the submit button again) would make for a better UX and be a nice touch! 😉

  Keep coding (and happy coding, too)! 😁

  12
• 

  Guy Ezra•615

  @ezraguy

  Posted over 4 years ago

  Hey @Etang131, I have 1 suggestion to offer, I think the image component should not be in the container. because the container has a max-width:1440px and when you look at the website with a desktop monitor there are white spaces on the sides because the screen is wider than 1440px. what I would do is would take the image out of the container CSS as a background image and add it as an img tag and give it the following CSS:

  .background-img{
  position:'absolute';
  width:100%;
  height:100%;
  z-index:-1;
  }
  

  other than that it looks great! Happy coding! 😄

  11
• 

  Web Frog•1,840

  @MasterDev333

  Posted over 4 years ago

  Great work @Erik. However, you should remove overflow hidden for body tag when it goes on mobile. Now, I can't scroll down. ;) Happy coding~ :)

  11