Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Intro Component with Signup Form

Hyunji Kim•155
@creativehkim
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello all! I really enjoyed this project :) For the "success modal" I made, I made it open when it's submitted by clicking the bottom button, but I couldn't figure out how to make it open only when all fields are correctly filled... also I made two close buttons on the modal (x button on the top right and 'ok' button) but only x button works and somehow 'ok' button works like the submit button in the form and does not close the modal. If anyone could go see my code on git and give me some kind of feedback, I'd appreciate it so much!

Thanks for checking it out :) happy coding!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ana Luz Cervantes•1,705
    @analuzcervantes
    Posted over 4 years ago

    Hi Hyunji Kim! 🖖

    Good job on the challenge! 👏 I like the validation you did ❤

    If I understood correctly what you want to do... You can do it with a blur event, you can answer me here if you need more information 😊

    I would like to give you some advice:

    • The width of the page is a little bigger, you need to remove the width 100vw from the body
    • To solve problems for inputs name available to an accessibility API: Add aria-labelledby attribute to all the inputs (you can check this in your HTML issues report)

    Keep coding! 💻👾

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub