Martin• 1,150
@ringm
Posted
Hey Alex! Great job! The site looks great. I have tiny suggestions to polish it.
- Center the main container so the content sits nicely on the middle of the screen (in your case, maybe adding
margin: 0 auto;
on the<main>
. Although as a better practice, I would suggest wrapping everything in a<div>
and give it acontainer
class. - Your
<input>
should have<label>
, that's why you're having html issues on your report. Also, consider wrapping your forms with a<form>
, it's a better practice from the semantic point of view
An example would be:
<form>
<label for="firstName">First name:</label>
<input type="text" id="firstName" name="firstName" value="John">
<label for="lastName">Last name:</label>
<input type="text" id="lastName" name="lastName" value="Doe">
</form>
Just tiny things! Overall it's a great job! Keep at it!
2
Alex Camacho• 205
@alexcamachogz
Posted
@ringm Thanks! I fixed accessibility issues for the project :) In my next projects, I will pay particular attention to these details.
0