Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro Component with Signup Form Solution

#accessibility#bem#less#parcel

@peterhannell

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'm mostly happy with how this turned out. A quick note though: I stuck to the static designs but I really should have made it responsive. Next time I think I'll use something like Bootstrap.

HTML, Pug, LESS, Vanilla Javascript. Built with Parcel.

All feedback is welcome/appreciated, especially with my JavaScript code as I'm still very new to it.

Community feedback

Account Deleted

hey @peterhannell! great work here!

I am going to give you some small suggestions to improve your code even more, which by the way looks very clean :)

  • heading levels should only increase by one, could you fix this by changing this h3 tag to an h2 or a p tag:
<h3>
  See how experienced developers solve problem in real-time. Watching
  scripted tutorials is great, but understanding how developers think is
  invaluable.
</h3>
  • <html> element must have a lang attribute, this is very easy to fix:
<html lang="en">

I hope this feedback has been useful to you! keep coding :)

Marked as helpful

0

@peterhannell

Posted

@nachogonzalia

Thanks for your feedback/suggestions. I'm not sure how I was missed the <html> tag!

1

Account Deleted

@peterhannell hahaha these are things that happen to all of us!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord