@rfilenko
Posted
Hey Dave, good work on this one. You can improve further by optimizing you js code - define variable only once on the top, use one function with if statement inside to not dublicate your code. Also you can wrap the whole code inside self executing functionπ
And work on feedback about styles.
Cheers, Roman
@rfilenko Thanks - all clear on the JS issues. Can you clarify what you mean by 'And work on feedback about styles'? I'm not quite getting you. Thanks!
@rfilenko
Posted
@dwhenson Hi, what I meant - work on small details of your submission, to make it as close as possible to the design file. Read through previous comments also π
Have a good one, Roman
@rfilenko Thanks Roman. Appreciate the clarification. I'm not sure I can use an if statement in this case as two different events are being emitted? I'll look into this a bit more though. Thanks for the advice!