Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Intro component with sign-up form with HTML, CSS, Flexbox, Grid, JS

Purbo•330
@Targitay2012
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I will be glad to any feedback!

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted over 2 years ago

    A few important html tips

    • you shouldn't have empty divs for any reason. If you need to put a background image on the whole page put it on the body
    • every input must have a label
    • the error icons are decorative so alt must be empty if placed in html. Or you could make them background images on invalid inputs if preferred
    • the error messages should be wrapped in an element that has an aria live attribute on it and a unique ID for each one
    • the inputs need aria describedby pointing to the id of its error container

    All of these things are important habits to get into as soon as possible so you write accessible forms.

    Marked as helpful
  • Vanza Setia•27,715
    @vanzasetia
    Posted over 2 years ago

    Hi, Purbo! 👋

    I totally agree with @grace-snow regarding the form validation. By following Grace's suggestions, it will make the errors get announced to the screen reader users.

    I wrote an article about creating accessible form validation. It will tell you how to create it step-by-step to create accessible form validation by using aria-live and aria-describedby.

    About the input's label, it needs to have text content. Wrapping the input with label doesn't make the input has an accessible name. I recommend having a span with visually hidden styling or using aria-label on the input element instead.

    For your information, @ is an at sign. You may need to rename the variable on JavaScript.

    By default, the body element has 16px. I would think if the style-guide is telling that the body font size is 16px that means it follows the users' browser's default font size. So, there's no need to specify font-size: 16px.

    Also, code your font size in rem, not pixels. This means the text size will be responsive if people want to adjust the size.

    I hope this helps! Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub