Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro Component with sign-up form

Obi Zim• 195

@Obizim

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


If you happen to see this, please I request your feedback

Community feedback

Ynnk• 170

@HYannick

Posted

Nice work on this!

Maybe use more readable class name for &__h1-> &__title and &__p-> &__description

On the JS side there could need some refacto on the error handling part.

Maybe wrap on the html side the errors like so:

<div data-error='firstname'  class='error'>
    <img id="img1" src="./images/icon-error.svg" alt="error-icon" />
    <span>First Name cannot be empty</span>
</div>

and then on the js side use a validator function that will map the error depending of the form data provided, and add the error class with the right styles depending of the right data-attribute (I don't know if I am clear ahah)

1

Obi Zim• 195

@Obizim

Posted

@HYannick Thank you Will definitely check it out

0
Sahas saurav• 745

@SahasSaurav

Posted

reduce width of form it looks like stretch out and you have change the color of placeholder to red and by the good work

0

Obi Zim• 195

@Obizim

Posted

@SahasSaurav Alright Thanks

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord