@ryancalacsan
Posted
Good work on getting it super close to the design! Upon quick inspection I did notice a few things that may be worth looking into.
-Your current email validation seems to work on leaving it blank but is not currently checking to be a valid email.
-I would take a look into your error icon positioning. While they are in place for your desktop view, once you get to the mobile view they fly off to the right.
-Lastly I would look into your media queries and or spacing when resizing your window. There is a point between the two where your text starts to get cut off.
I am happy to go into more detailed solutions if you'd like but if you're anything like me, I learn/retain better when trying to work things out on my own first :)
Overall, great job and happy coding!
Marked as helpful
@sorengrey
Posted
@ryancalacsan Thank you for all the feedback! I will be trying to fix these things today. I didn't realize my email field was letting people get away with that, haha!
@sorengrey
Posted
@ryancalacsan Ok, got the email validation fixed. It worked before I added the check for blank fields, lol. Thanks for catching that!
I also adjusted the break points so that the text doesn't cut off.
Oh wow, that exclamation point really did end up somewhere weird. It's fixed now!