intro section built with html, css and javascript

Solution retrospective
I had a little bit of challenge building the hamburger menu for the mobile view especially on making it close when the use clicks outside of it and dimming the background of the page when the hamburger menu opens. Although I was able to work around it and get it to work well but I think there maybe be a better way of doing it.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Varghab
You did great work 👏, however I have a few suggestions -
- Don't use both width and height properties for your images. Doing this will shrink your images.
- Use an additional wrapper div for your hero section and give flex property to that wrapper.
- Lastly, the site is not responsive for tablets. Try to make it responsive for tablets.
- @mukwende2000
The code for the hamburger could have been written like this
hamburger.addEventListener('click', toggleMenu) function toggleMenu() { if(navMenu.classList.contains('active')) { navMenu.classList.remove('active') } else { navMenu.classList.add('active') } }
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord