Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

Intro section with dropdown navigation

next, sass/scss, react
Andro87•1,460
@Andro87
A solution to the Intro section with dropdown navigation challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback on how to improve my solution is welcome! ;)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Kerry Convery•0
    @kerryconvery
    Posted about 3 years ago

    Hey, I like the layout of your site. I found your design to be clean and simple with good contrast.
    There are a few things I think could be improved however.

    Firstly the site menus don't seem to work properly, there is no highlighting happening when you hover over a menu item plus clicking on those items doesn't seem to do anything. There is also no focus indication on the menu items or buttons which isn't good for accessibility I guess it is still a work in progress though.

    The second thing is the code, I only looked at the pages/index.tsx but I found it very hard to follow. It would be best to define components for each of the things that make up the page and then have index.tsx simply be a composition of those components.

    Finally, instead of calling it index.tsx, name it after the name of the page, like home.tsx, or about.tsx, as well as give your components meaningful names. This way when someone (or even future you) comes into the repo they can immediately see what the site is about and how things are organized. The code and the layout of the code should guide the developer.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub