Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro section with dropdown navigation

#jquery
Vaniโ€ข 160

@VANIMEHTA

Desktop design screenshot for the Intro section with dropdown navigation coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I have used jquery in this project and my site was working perfectly fine before deploying it. ie all the dropdown menu and active states were working. But none of this feature is working after deploying Can someone pls help with this!

Community feedback

Sean Redโ€ข 635

@seanred360

Posted

I have fixed the issue with your dropdown menu. Please check my pull request on GitHub to merge the changes. The problem was you have deprecated jQuery code, you need to use the new syntax or it won't work correctly. You can go to the GitHub page and click on the Issues tab, next to <> Code and Pull Requests to see the bugs I have found and how to fix them.

Marked as helpful

0

Vaniโ€ข 160

@VANIMEHTA

Posted

@seanred360 hi, thank you so much for helping out.But i just merged your code into mine and the dropdown menu is still not working and I couldnt figure out why If you could help with this please.

0
NotBenjaminโ€ข 70

@Aeteung

Posted

Try to use a closing tag instead of a self-closing tag for the script tag

0
Tesla_Ambassadorโ€ข 2,980

@tesla-ambassador

Posted

Hey Vani, congratulations on completing this challenge, it looks pretty solid! ๐Ÿ’ช Here's a few pointers that could be useful:

  • I looked through your code and ran it on github desktop to findout what the jQuery problem was, sadly I couldn't figure it out because it also ran on mine and if I am being honest, I have used very little jQuery but once I come up with a solution, I will notify you!
  • In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like <main> or <header> or <footer> you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link.
  • You need to add an alt text to your images. This is because it tells the browser what image is being displayed and this can also help those using screen readers to know what image is being displayed on the website. It will also clear some of your HTML validation issues and accessibility issues

Happy coding and keep up the great work! ๐Ÿ‘

0

Vaniโ€ข 160

@VANIMEHTA

Posted

@tesla-ambassador thank you ! noted.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord