@elaineleung
Posted
Hi Joel, this looks good! The mobile nav works, and the dropdowns also. I think you did well also in keeping the image and text containers at a good size and at optimal views.
Some other comments:
-
I notice that at mobile view before the breakpoint changes, the image becomes stretched out. You'll need to add an
object-fit: contain
, and that should fix it! -
For
.hero
at mobile view, you can trywidth: min(100%, 80rem)
instead so that the text doesn't stretch out as much, and then at desktop view, you can either just usewidth: 100%
orwidth: min(100%, 80rem)
so that things don't stretch out too far here. If you usemin()
, be sure also to addmargin-inline: auto
. -
For the React side, I think you can try making a component for the links since they appear quite repetitive, and they can practically can be made into a component.
That's about it, great work since it is not easy to make this look good!
Marked as helpful