Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

intro-component-with-signup-form-master

@MedtheVorg

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


any feedback is welcomed 😁

Community feedback

Anar 700

@anar-sol

Posted

Hello! The overall styling looks good, but I have some remarks:

  • Why not use the HTML5 built-in form validation? https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation

  • You are using a simple <input type='text'> for the email, and you are not checking if it's a well formed email.

  • You use hard codded error messages in your HTML code, what would you do to report two different error messages for one entry? (supposed to be the case for the email)

  • Instead of using inline css to style error stat, you could just add a css class (with JS) when there's an error.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord