Alex Kim• 1,325
@alex-kim-dev
Posted
Nice try on this challenge! Here are a few things you can improve:
- i think the background for this challenge is intended to be fullscreen
- not all text elements use provided fonts
- try to use custom js validation instead of the native one, add feedback messages for empty inputs as mentioned in the design
- interactive controls' states should be styled (
:focus, :hover, :active
) - using floats for layout building can cause some problems, more appropriate solution is to use flexbox / grid
- i don't think the upper blue thing should be a button, to me it's a heading inside of the form
- try to be more descriptive with the values of
aria-label
, eg 'Signup form' instead of just 'form' - there's no need to put
br
between the inputs
1