IP Address Tracker | React & TailwindCss

Community feedback

• 

  Dario Rodrigues•160

  @Unidade

  Posted over 2 years ago

  I looked your javascript code and I found that you a are making more fetch calls than the necessary, I inspected this with the network section on devTools. This is an example that are present in your components:

  {fetchLocation(ip).city}, {fetchLocation(ip).country}
  

  The response of this fetch call is a data object that have all the properties that you are accessing, you can be more efficient if you store the fetch data in a variable and access them as need. For example, this only make a fetch call.

  const data = fetchLocation(ip)
  {data.city}, {data.country}
  ...
  

  This is important because you don't want to make unnecessary call to the server, they can bottleneck your app, you are using more of your api call quotes and isn't efficient at all.

  13

  Marked as helpful
• 

  Tommy Tabe•150

  @tabetommy

  Posted over 2 years ago

  Your solution looks really good especially the improvised box at the right showing the route planner linking to google map. It will be really look closer to the given design if you adjust the UI containing the IP address informations to the center of the border between the map view and background image at the top. You could use position relative for parent container and position absolute for child container to achieve this. Also, frontend mentor platform reports an error on your iframe element. something about attribute loading not allowwed. Honestly i don't know much about that but you can check.Otherwise i think your solution looks really good, functional and responsive

  11

  Marked as helpful