Submitted 5 months ago

j'ai applique le css a l'interieur du html

MOUHAMADOU80•50

@MOUHAMADOU80

A solution to the QR code component challenge

Preview Code

Solution retrospective

What are you most proud of, and what would you do differently next time?

je suis fiers d'avoir realise mon premier projet

What challenges did you encounter, and how did you overcome them?

j'etais bloque sur comment pousser l'image au milieu et finalement j'ai utilise "position" pour le faire

Code

Please log in to post a comment

Community feedback

Anastasia•180
@Asyalapa
Posted 5 months ago
Great job! This project provided a good opportunity to practice font integration. For easier positioning, using flexbox would have been a good choice, as it simplifies element alignment. Also, it's considered best practice to separate styles into an external CSS file for cleaner and more readable code.

I noticed that the favicon is missing—perhaps there’s an issue with the file path. Additionally, the border-radius could be set in pixels since the QR code has a fixed size and doesn’t change across different screen sizes.

Another small improvement: the pre tag is used for formatting text, but in this case, a regular p or h3 without pre would be more appropriate to avoid unnecessary spaces. Also, in @media screen, the body width is missing a unit of measurement (it should be width: 360px).

Overall, a solid effort! With a few refinements, this project will look even better. 🚀
Marked as helpful
heffs•120
@heffs
Posted 5 months ago
Bonjour ! Dans le <body>, mettez « height:100vh; display:flex; justify-content:center; align-items:center » et votre <figure> apparaîtra au centre. Et supprimez le paddingde « img » et placez-le plutôt sur « figure ». Ensuite, votre image aura quatre coins arrondis.
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord