P
Matt Studdert• 13,611
@mattstuddert
Posted
Hey Hannah, nice work on this challenge and congrats on submitting your first solution. I've got a few tips after taking a look at your code, but also just a quick heads up. In the title, you've written "Java and CSS using flexbox", but just be aware that Java and JavaScript are two very different programming languages.
Here are some pointers:
- You're writing text in uppercase letters in your HTML, which will make screen reader software read the words out letter-by-letter. This makes that content inaccessible to people using screen reader software. A better approach is to keep the content lowercase in your HTML, but use
text-transform: uppercase;
in your CSS to visually alter the text. - Your navigation links are currently in a paragraph tag, whereas an unordered list might be more appropriate. This has the benefit of screen reader software announcing how many list items there are in the navigation.
- Using semantic HTML5 elements as opposed to
div
elements can give more meaning to your HTML structure. - If you would like to make the page responsive, but haven't learned it yet, here is a great tutorial by Udacity on building responsive websites.
I hope these tips help. Keep up the great work! 🙂
0