Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 10 months ago

Javascript fundamentals Dom & event listners

accessibility, bem
Mohit kulkarni•170
@burningbeattle
A solution to the Article preview component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I’m most proud of successfully implementing the interactive share button feature using JavaScript. The share option is neatly integrated and displays only when the button is clicked, creating a clean and dynamic user experience. I would focus more on accessibility by ensuring better support for screen readers, adding ARIA attributes, and making sure the share option is keyboard-navigable. I might also explore more modern tools like CSS Grid for layout flexibility or CSS variables to allow users to easily change themes.

What challenges did you encounter, and how did you overcome them?

I used CSS translate and scale to control the animation, making sure the share option is hidden until needed. Getting the correct toggle behavior on the share button required precise event handling. There was an initial challenge with the button not reverting to its inactive state after clicking. Solution: I resolved this by using the classList.toggle() method in JavaScript, ensuring smooth interaction by dynamically adding and removing the necessary classes.

What specific areas of your project would you like help with?

I’d appreciate suggestions on improving the accessibility of the share option and the overall page for users relying on keyboard navigation and screen readers. Although the CSS transitions work well, any advice on optimizing animations for smoother performance, particularly on lower-end devices, would be valuable. Any recommendations on cleaning up or optimizing my CSS and JavaScript structure, especially in handling interactive elements, would be very helpful.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    edpau•470
    @edpau
    Posted 10 months ago

    I think you have already done a great job on optimising animations, you only used transform.

    I found an interesting article. Explain in more detail if you are interested. "Modern browsers can animate two CSS properties cheaply: transform and opacity. If you animate anything else, the chances are you're not going to hit a silky smooth 60 frames per second (FPS). This post explains why this is the case."

    For accessibility, I read this and tried to use aria-expanded, aria-controls and aria-haspopup to improve the accessibility of the share menu. These attributes help inform assistive technologies about the current state of the expandable menu. However, improving accessibility has turned to be more challenging than I expected. For the mobile version, I need to hide the author content from screen readers, while for the desktop version, it doesn't need to be hidden. There are many factors to consider. Do you have any suggestions?

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub