Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 11 months ago

Job Listing with Vue 3 using composables

sass/scss, typescript, vue, vite
ricardoychino•190
@ricardoychino
A solution to the Job listings with filtering challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Perhaps the use of composable to extract the filters based on the entries and to handle the local storage. But in some aspects the solution was overcomplicated and I feel kind of uncomfortable by including so many properties in the value returned by the composable. I'm not sure if that was a good practice, probably not

What challenges did you encounter, and how did you overcome them?

The TS errors in the IDE and the logic inside the tags composable. I searched for ways to solve the issues by altering the configuration of the project; and as for the logic, I tried to simplify the initial logic using JS data structures like Set and Map

What specific areas of your project would you like help with?

The logic in the useTagFilter. I created an internal Set where each filter applied is added as a string containing the property name and value (for example, 'tools-Vue'), because if the entries are created by the user typing the values, it is possible that 'Vue' could be added as a language instead of tool or something like that. That said, I return a mapped array removing the key from the string.

I see some problems with that approach:

  • I maintained the list filtering logic (the function isResult()) inside the composable
  • Too many items on the object returned by the composable
  • In the CurrentFilters.vue component, there's no way to know from which property that value is, and that's why I created a keysByValue map. But I feel that it was pretty much unnecessary and waste of memory
  • In localStorage, the full joined string is saved, ie. tools-React,tools-Vue,contract-Full Time for example. Saving only the values would be much more functional, but if I do so, the problem is to know from which property that value is

I wanted some feedbacks or insights about that logic, because while I am happy that I finished it and it is functional, I can see that there are bunch of flaws and I feel this is not a optimal approach

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

No feedback yet. Be the first to give feedback on ricardoychino's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.