JS, CSS and HTML

Community feedback

• 

  Martin•1,150

  @ringm

  Posted almost 5 years ago

  hey Kushank! Great job on completing this challenge, the site looks really good! Identical to the original! I have some minor suggestions that can make your site look even better:

  • The JS looks good, however I would encourage you to build some animation for the transition between slides. I would look much more polished and eye catching. [Here's my take on the challenge] (https://www.frontendmentor.io/solutions/sass-grid-and-css-animations-OG4YmHISD) if you want to check how I implemented them.

  • The site is not centered when you view it on large devices, I suggest adding the old margin: 0 auto; to the container class to achieve that ;)

  Keep up the good work!

  Cheers,

  Martin.

  30
• 

  Rafael La Buonora•160

  @rlabuonora

  Posted almost 5 years ago

  Great solution! Adding to what Martin said above about centering and transitions (I haven't implemented transitions on my solution either), I noticed the next and previous slide buttons are in the middle of the image.

  I used absolute positioning to solve that, here is my solution in case you are interested:

  https://www.frontendmentor.io/solutions/plain-css-and-js-solution-2I4ATIl5l

  00