js flex

Community feedback

• 

  P

  Katrien Schuermans•1,420

  @katrien-s

  Posted 4 months ago

  Not that much to add actually. Your solution looks really good. Are you going to continue writing your js and css inside your html?

  As for your image, look into how to use <picture> to have responsive images instead of showing and hiding mobile and desktop image.

  • Responsive images
  • The picture element

  The padding on your form-container is not equal on both sides. You have set a padding-inline: 3rem 2rem which really shows on mobile view. But it also gives too much white space on desktop view.

  There's something really strange here. When I look at your code on Github and the code of your webpage, I see 2 different solutions. Your webpage does not have inline styles and JS. It shows the too much padding on 'form-container' while on Github it says the padding is on detail. Are you copying in other people's webpages? If so, I stop giving feedback here as I am not looking at your solution but someone else's.

  00