@GlenOttley
Posted
Hey Brad!
Good work on this one, the implementation is nice and responsive. I particularly like that you took things a step further by implementing authentication via supabase, this is something I will definitely look into doing for my own solution. Also the '+ Add a new task' button in the empty columns is very nice too.
I can make a few recommendations if you don't mind.
-
Add some form validation to the new/edit task/board forms to prevent empty items being submitted.
-
Your modal implementation does not trap keyboard focus. When a modal is opened, keyboard focus should generally be moved to the first focus-able element. If the user tabs through the modal, the focus should 'wrap' around the focus-able elements, so that if the user presses tab on the last modal element, focus moves back to the first modal element.
-
Try to make your touch targets larger. For example, your ellipsis (triple dots) which open the edit/delete task/board menus. Whilst these are possible to click with a mouse and some dexterity, they are difficult to use on a touch screen, especially for less able users. I recommend adding some padding to these elements to resolve this.
Keep up the hard work !
@bradvatne
Posted
@GlenOttley All great advice, especially the modal implementation stuff. I wonder if I could use the <dialog> element as well.
Thanks so much for taking the time to review my project! Thats very kind of you. I will take some time and check yours out as well!
Right now I'm working on the Netflixy kind of app on here. I've opted to try out Express and MongoDB, and suffice to say NextJS has truly spoiled me! Would love to compare answers if you get around to doing that one too!
