Landing Page

Community feedback

• 

  Abdullah Nassif•405

  @AbNassif

  Posted almost 4 years ago

  First of all, really love your attitude towards knowing you made mistakes. We all do, and they are essential in making us the best at what we do.

  1- Love that you took the initiative in making the navbar fixed to the top as someone is scrolling. But I can't see the links once I've scrolled, so consider adding a darker background once a scroll is initiated. (Google ways you can do that, but I think you most probably need javascript for that)

  2-The nav bar isn't responsive because you added padding of 45rem to the right for the li.left-nav. That is a big no-no in the css standards, as it won't scale well on any other device other than one's similar to your screen.

  To fixed that, remove the logo from the ul all together and add it to a separate div.tag (It should be the ul's sibling instead of it's child). Then a super easy way would be to add another div tag in between the logo and links and give it a margin of auto. That way it'll take up the whole space of the nav bar and align them perfectly across all screens.

  (There are plenty of other ways, but this is the easiest of them all)

  3-Always and always fix the responsivity of the section before creating another one, I did that once and it ended really badly for the project I was working on. Learn media queries and read about responsive units(Vh,VW,%) and how you can use them to reduce the code required for mobile responsiveness.

  4- To fix the orange missing as the viewport changes, just change the "background-position" property to "bottom" in media query.

  5- You forgot to add the milk image above the footer. Just add a display of flex, then give all of them a specified width to fit the viewport, and add flex-wrap to break the down vertically as the viewport get's smaller. You could then use media queries to increase their width as each image get less competition for the row it's in.

  Honestly couldn't figure out the reason behind the whitespace between the images in the center, and why they're taking 150% of the screen size(having to scroll horizontally), But It's so messy and it would be counterproductive to spend your time fixing it now. So just pat yourself on the back as this challenge isn't as easy as it seems, and remember to break everything down next time and make sure that each part is mobile responsive before moving on to building the next part.

  Great job!

  11

  Marked as helpful
• Account deletedPosted almost 4 years ago

  The picture with the orange is missing on desktop, it like literally disappears.

  21