Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Landing Page using Mixture of Grid and Flex to layout elements

Elias Lind•130
@EL132
A solution to the News homepage challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


How would I change my current design to be responsive?

I used a mixture of grid and flex for my displays; is this frowned upon when developing a frontend page?

How long should the color pallet and layout planning period be when beginning a website from scratch?

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Account deletedPosted almost 3 years ago

    Firstly do not set an explicit width on the body. You should create a container that stores everything inside of it, and you can give it a max-width. That way it is flexible but will never grow past the maximum width you have set. As of now, your code is completely non responsive firstly because of using the fixed width on the body. Secondly you should start by designing the mobile view first. This is simple because everything just stacks on top of each other. You don't need CSS grid for Mobile. Once you have the mobile design looking perfect, expand the screen until the mobile design starts to look a bit weird, this will be your first media query. Place a media query for this screen size and change the design elements inside this media query until it looks good again. You already understand CSS Grid by the looks of it, so this should be easy to do. That's pretty much it, just try and avoid setting explicit widths on anything if you can, you want the content to be flexible, use max-width instead.

    Marked as helpful
  • Jair Rodriguez•310
    @Jairth
    Posted almost 3 years ago

    Hello, I advise you to add semantics to your page. On the other hand, some people find it easier to start developing first for mobile and then for desktop, maybe that can help you.

    You should also add break-point to make the respective changes between mobile and desktop. In my opinion, you can use Flex and Grid together, both are powerful tools.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub