Skip to content
Submitted about 4 years ago

Launch countdown timer with Html Sass and Vanilla Js

Dark-Lover•735
@Dark-Lover
A solution to the Launch countdown timer challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

hey my friends in this challenge iv used sass again, i dont know if im doing it in the right way, if someone can check my scss file (js file too) and give me a feedback, i will be grateful. waiting your feedbacks ;)

Code

Please log in to post a comment

Log in

Community feedback

  • Claudia Benito•75
    @claudiabdm

    Hi!

    Great work on this tough challenge. I agree with ApplePieGiraffe and I'd recommend avoiding IDs for the reasons already mentioned. I saw you have used SCSS variables so that is the way to go 👏

    I have also noticed you used fontawesome with the icons. While this is totally fine, you can also import svgs in your html or use them inline instead of using third party css. Lastly, do not forget these icons are links to social pages, so it would be nice to use an anchor tag to wrap them.

    Keep up the good work 💪

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Hey, Dark-Lover! 👋

    Nice work on this challenge! 🙌 Kudos for delving into Sass and JS some more! 👏

    The only small thing I have to suggest after taking a look at your Sass is to probably avoid using ID's to style things, since that's generally considered a bad practice and can making styling large sites difficult because of their high specificity. 😉

    I haven't completed this challenge yet, but a great solution for this challenge (where you might be able to learn a thing or two) that you may want to consider checking out is this one from tediko. 🙂

    Keep coding (and happy coding, too)! 😁

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord