List Of countries with REST API

Solution retrospective
It’s my first time building a multi page project (don’t know what they call it SPA when it’s clearly MPA). I’m proud of myself, as I’m improving my ReactJS skills
What challenges did you encounter, and how did you overcome them?The challenges are too many to mention. How I overcame? Well… let’s say it helps to have a quality support system and networks.
What specific areas of your project would you like help with?Any advice will be helpful. And yes I didn’t use the best of the “best practices”.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @dylan-dot-c
Hey well done with this challenge it looks excellent!
I think there are a few things to improve
-
Firstly accessibility. I see why you have an handle navigate function to programmatically change the route on click, but one draw ack is accessibility, like a user limited to their keyboard won't be able focus on that country and cant click on it. One solution is to wrap it with an anchor tag so that will be presented as a focusable link.
-
I realized you had a json file with all the countries, and while that ain't a bad approach, it would be good approach to use ajax or just fetch to get from the real API, and use other API endpoints to get the specific country, instead of passing in the data down(still isn't a bad idea and you don't have to worry about the countries API failing).
-
I think you can look up tanstack query to see another way of fetching data from an API.
Anyways, take a look at my solution did it awhile so forgive the react code, I need to update some things. But tell me what u think
-
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord