Hi,
Just had a look on my phone and this looks excellent. You've done a really nice job.
Where you definitely need to make improvements is in making your solution accessible
- add aria-labels to the open/close buttons for the nav
- add meaningful alt text to the logo image whenever it is included (logo does not tell me what the product/site is called, it needs to be the name)
- see all buttons should actually be anchor tags not button elements, as they would be performing navigation
- footer nav needs an aria label (
footeris a fine value for this) - social icons need wrapping in anchor tags
- all interactive elements on the page need a visible focus style so people navigating by keyboard can see where they are.
Enjoy the tips and keep going, you're doing very well
1
Allan Guillotin• 330
@Allangui
Posted
@grace-snow
Hello Grace , thank you for you feedback i really appreciate ! I changed what you told me that was wrong.
Big thanks !
0
