Eray• 1,410
@ErayBarslan
Posted
Hey there, great work on this one! Design looks good and is responsive. My suggestions will be regarding semantic html:
- Using list on navigation elements (About, Careers, etc.) is right approach. Though you should wrap <ul> with <nav>...</nav> for better usage. Since there would be two <nav> in page. You can use label on them like
aria-label="top navigation"
- Again using list on socials is right appraoch. But they'll be links directing to the social page in production. So you should wrap your <li> with <a> like :
<a href="#"><li>...</li></a>
- For copyright instead <p>, <small> would be a better usage. Also when you use
target="_blank"
attribute on links, addingrel="noopener noreferrer"
will make it secure. Aside these everything looks great. Hope you find these helpful, happy coding :)
Marked as helpful
1
Jumagobe• 960
@Jumanjigobez
Posted
@ErayBarslan Thanks I appreciate your suggestions.
0