Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

loopstudios-landing-page using html,css and js

Mibeninā€¢ 490

@MIBENIN

Desktop design screenshot for the Loopstudios landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please review the code and give feedback!!

Community feedback

@VCarames

Posted

Hey there! šŸ‘‹ Unfortunately, there are a lot of mistakes been that I would not expect at this challenge level.

I noticed that you are not receiving feedback in your previous challenges, In that case I would recommend reading the feedback others receive to improve all your previous challenges.

Here are some suggestions to help improve your code:

  • The header should always be outsideāš ļø of the main element to make semantic sense.
  • Swap <section class="banner-section"> with a header element and <header class="header container"> into a div.
  • The logo's anchor should have an aria-labelāš ļø and it should state the company's logo name and where it leads to.
  • There is NOāŒ reason to have code for two separate navigation menus. There should only be one and you will CSS to style it for different layouts.
  • The navigation "button" has to be a built using a buttonāš ļø since it doing an action (open/close menu); Currently, it is not accessible.
  • Text should not be all uppercase <h1 class="hero-h1">IMMERSIVE EXPERIENCES THAT DELIVER</h1> as it is not screenreader friendlyšŸ˜¢, instead use CSS to do so.

  • The buttons in the creation portion should be anchorāš ļø elements, as they would most likely direct users to other parts of your site.

  • Skipping heading levels is something that is not allowedāŒ in web dev. In your case, you can't jump from h2 to h4.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! šŸ‘¾

Marked as helpful

0
Mibeninā€¢ 490

@MIBENIN

Posted

Thank you for your valuable feedback! I will surely make use of these suggestions while doing upcoming challenges..Please evaluate my previous challenges also.It will be very helpful for me to learn from my mistakes..

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord