Made the website using HTML, CSS flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  MAKING ACCESSIBLE LINKS:

  • The links like Github, Frontend Mentor are needed to be actual <a> elements which are wrapped up using li and ul elements. The button element is not appropriate to use in this solution. because button element can't be used for navigation purposes that's why we want to use a elements.

  ---

  • This is the current markup,

  <div class="container">
    <button> GitHub</button>
    <button>Frontend Mentor</button>
    ....
  </div>
  

  ---

  • In order to make this solution accessible, we need to use <a> elements with href attribute. Here's the example

  <ul>
      <li>
         <a href="#">Github</a>
      </li>
      <li>
         <a href="#">Frontend Mentor</a>
       </li>
      ...
  </ul>
  ....
  

  ---

  • If you have any questions or need further clarification feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  00

  Marked as helpful
• 

  Saidi•70

  @Selik254

  Posted about 1 year ago

  THANK YOU, I WILL TRY THEM OUT.

  00
• 

  karthickg24•130

  @karthickg24

  Posted about 1 year ago

  Congratulations on completing this challenge. Few Suggestions on your solutions that will be helpful for you in your upcoming projects.

  • Try to USE semantic HTML that improves your site accessibility
  • Regarding Avatar image, alt tag should have more meaning message like Avatar Image of Jessica Randall
  • Regarding Flexbox u can check out this POST from josh - Interactive Guide to Flexbox

  00