Submitted about 1 month ago

Made using plain HTML and CSS

Ismail Jabiullah•10

@IJabiullah

A solution to the QR code component challenge

Preview Code

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud that I was able to make it in very short time. But i Don't know if the approach is correct or not. It felt like bruteforcing it to look like the design.

What challenges did you encounter, and how did you overcome them?

It was challenging to deal with the image at first. Then I google my problem and it helped. But the very first problem was setting up git with global username and email.

What specific areas of your project would you like help with?

I would like to know if it was a good way to make this or was it "Bruteforcing"

Code

Please log in to post a comment

Community feedback

Muhammad Saif•350
@saif010101
Posted about 1 month ago
Hello, i am new to this website and relatively new to front-end development as well. I am also here to learn and improve.

Just two things i want to mention regarding your CSS file.
- Use CSS variables to improve readability and make code easier to maintain.
- According to the solution i think it is perfectly centered, so just add justify-content : center or remove flex-direction : column (body tag), since in this case it is just a single card.
Good job!
Marked as helpful
haquanq•2,015
@haquanq
Posted about 1 month ago
There is no brute-forcing here, no need to overthink.
- There is however different ways to simplify HTML structure, example would be remove .textDiv wrapper and your structure stay the same (div does not have semantic meaning, avoid using it, similar to span).
- Your page should contain one main landmark and h1 to describe page content.
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord