Mail validation using event listener

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  JAVASCRIPT 🟡:

  • The way you declared variables are need to be well structured and organized

  ---

  • Take a look at the following example code which describes a better way of declaring variables to have a well structured code

  const firstName = "Your";
  const lastName = "Name";
  const emailAddress = "example@some.com";
  const password = "supersecret";
  

  • instead try this,

  const firstName =  "Your",
         lastName =  "Name",
         emailAddress = "example@some.com"
         •••                
         •••         // n number of declarations
         password = "supersecret";   // make sure to add a semicolon at end of last declaration
  

  • This single line declaration with separated commas will helps you to have a better structured code and improves readability though

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  00

  Marked as helpful
• 

  Josh•1,120

  @josh76543210

  Posted about 2 years ago

  Hello @Sanjeet204,

  Congratulations on completing the challenge!

  Here is another suggestion to improve the look of your page:

  Center the social media icons inside their respective divs using flexbox instead of padding. The divs are already displayed as flex so all you have to do is add align-items and justify-content. These can be used to center the flex-items (in this case the icons) vertically and horizontally.

  Just add them to your divs like this:

  .icons > div {
    align-items: center;
    justify-content: center;
  }
  

  And then remove the padding:

  .icons > div {
    padding-top: 11px;
    padding-left: 11px;
  }
  

  Your icons should now be perfectly centered inside your divs.

  Hope this is useful. Happy coding!

  00

  Marked as helpful
• 

  Shivraj K•400

  @Shivraj-K09

  Posted about 2 years ago

  • Great job! It's good to see that you were able to achieve the desired layout using margin and padding instead of relying solely on positioning.
  • One suggestion I would make is to use const instead of let when declaring pattern since the variable doesn't need to be reassigned. It's a small change, but it can help communicate to future readers of the code that the variable is intended to be constant.

  ---

  Keep up the good work! and Happy Coding 😉🫡

  00

  Marked as helpful