maker-prelaunch-landing-page with vanilla JS animated with AOS

Community feedback

• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted about 4 years ago

  Hello there, Josuke! 👋

  Good work on this challenge! 👍 The on-scroll animations in your solution are very nice! 😀

  I'd like to suggest,

  • Adding a max-width to a few of the sections of the page so that they maintain their size when the screen width grows larger (and don't start to seem stretched or anything).
  • Perhaps making the heading of the hero section of the page a tad bit bigger in the tablet/mobile layout (it seems a little small).

  Keep coding (and happy coding, too)! 😁

  11
• 

  Raymart Pamplona•16,040

  @pikapikamart

  Posted about 4 years ago

  Yours is really good and those observers , are those observers? I don't really use react but I use other api for that one. For the BEM, well we use BEM to be reusable right, but the thing is that, we just don't use them because they are easy to use since we can just declare one block then just append their child names right. We use them so that we avoid multiple stylings. We should first look at the layout then take note of different sections and look for the similarities of it, that similarity will be our block in BEM naming. Then we'll just add the states, in the manner of -- syntax. One best example of this is using a block of flexbox, since you can just manipulate any layout just using that and just adding different states like flex--column which will be flex-direction something like that. Well it just takes time to properly grasp BEM principles but that is the gist of it. Really, your work is good^

  14