Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 21 days ago

Manage Landing Page solution

Mohamed Biomy•920
@MohamadBiomy
A solution to the Manage landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What specific areas of your project would you like help with?

Any feedback will be helpful ❤️

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • leodev•570
    @hangtime319
    Posted 19 days ago

    Congratulations!!

    Marked as helpful
  • P
    Andrey•4,580
    @dar-ju
    Posted 21 days ago

    Hi Mohamed Biomy!

    Great job, but I see you don't have a tablet version, with a screen width of 600-1100px the content doesn't fit on the screen. You don't necessarily need a design layout for this, it's enough to just move and compress the blocks.

    What can be added\improved:

    • for better semantics for all content that is between the header and footer, you need to use the <main> tag, for the menu there is a <nav> tag
    • where the listing 01, 02, 03 is a list of ol\li
    • the logo in the footer is a different color
    • the list of social networks is also a ul\li list
    • the location of the blocks inside the footer differs from the layout
    • if clicking on something causes some action, then it is better to use <button> for this, you need to fix it for the burger and close burger buttons
    • the avatar images do not have alt, this is a error, alt can be left empty, but it should be

    Layout is precisely attention to detail.

    Good luck with your future projects!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub