Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

Meet landing page SCSS Grid/Flex

sass/scss
P
Matthef•190
@MatFrat95
A solution to the Meet landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

This was very problematic project, from the very beginning I faced multiple problems with particular elements, mixins, responsiveness and much more. The most important fact is, I solved all of those problems and learn a lot from my own mistakes.

Besides that, I know also what should I improve to write better code, I will implement knowdledge i obtain here in upcomming projects to create code easier to read and edid and more reusable.

I also implemented mixins with variables and used scss to divide code between separate files, thats very handy. Ill try to use more varibles other than colors in next projects and clamp() as font size unit.

What challenges did you encounter, and how did you overcome them?

I had problems with:

  • using mixins to with variables included, it was hard for me tu understand why my code was not overwriteable for @media (found out I had to put images to separate section)
  • correct order of files in workspace which cause problem with emulating site via github (trial and error)
  • responsivenes of site obtained by flex and grid used as mixins I'm sure there was a lot of other problems but those took me the most time to fix on my own.
What specific areas of your project would you like help with?

Can i use 'margin: -3rem;' to move element up? And .. why I can't see picture from footer here and I can see it on live server? Besides that I will appreciate if anyone give me any feedback :D

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Kumani Kidd•170
    @amancalledkidd
    Posted 4 months ago

    Great work - the landing page looks great, matches the designs and is completely responsive!

    • Good use of semantic html. I would recommend using the <header> and <footer> tags instead of a section or div as this helps screen readers.

    • Code is well structured, well done with the mixins and seperations of scss. Also with the comments it is very readable.

    • negative margins can be useful to get content in the right place but can lead to issues on different sizes screens

    • In regards to the footer img, this is happening because (line 44 inside _media.scss) background-image: url(../../starter-code/assets/desktop/image-footer.jpg) the url is incorrect as you have an extra ../. What you have written is correct if using _media.scss directly. But because the css is being called inside style.scss which is a level up it does not need the extra ../.

    Again great work, hope this feeback helps!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub