Minimalist Portfolio using HTML, CSS, Javascript

Community feedback

• 

  P

  Christopher Adolphe•620

  @christopher-adolphe

  Posted over 3 years ago

  Hi @Jeth0214,

  You did a great job for this challenge. 👍 I have check your solution from your git repository and everything is nice and neat there. 👌 I like the approach you have used for the portfolio. I only have the following suggestions.

  • You should refrain from using id selectors in your CSS because it hinders on the reusability of style.
  • I saw that you are handling responsive images via JavaScript. I recently found that there is nice alternative to achieve the same result. Maybe you can give it a try. 😉 Read more here

  <picture>
    <source media="(max-width: 799px)" srcset="elva-480w-close-portrait.jpg">
    <source media="(min-width: 800px)" srcset="elva-800w.jpg">
    <img src="elva-800w.jpg" alt="Chris standing up holding his daughter Elva">
  </picture>
  

  • You might want to wrap asynchronous logics in a try...catch block like this:

  async function renderProjectsToTheView(width) {
      try {
          let response = await fetch("../assets/json/projects.json");
  
          if (response.status === 200) {
              data = await response.text();
          } else {
              throw new Error(`Error: ${response.statusText}`);
          }
  
          projects = JSON.parse(data);
          device = checkDevice(width);
          getProjectsData(projects, device);
      } catch (error) {
          console.log(error);
      }
  }
  

  And yes, you can absolutely use this as your portfolio website but I would suggest you to spice it up a little bit more so that you come up with something unique because I think many have had the same idea of using this project as their own portfolio. 😉

  I hope this helps.

  Keep it up.

  22

  Marked as helpful
• 

  P

  Dave•5,295

  @dwhenson

  Posted over 3 years ago

  hey @Jeth0214, the site looks good!

  Definitely look into using a HTML solution for managing your images! My only other suggestion is to perhaps put a min-height on the body as in the contact page your footer is no longer at the bottom of the page which looks odd.

  I actually adapted this challenge for my only site, it still need work, but you can have a look here - https://dwhenson.com/ you might get some ideas of changes you could make to give it your own style.

  Cheers Dave

  11

  Marked as helpful
• 

  P

  Jason Nembhard•320

  @jNembhard

  Posted over 3 years ago

  Hey @Jeth0214,

  This a great attempt at a portfolio, but I'd suggest you re-do it completely after you build more projects.

  Why? Looking at what you have now, the implementation is clean and understandable, but people who hire also like to know why you make certain design decisions and used certain coding tools. If you started with a framework, you could've cut this down to 3 static pages and one dynamic page instead of 7 static pages.

  You did exactly what the instructions said, and that's a good start, but what can you do to make it yours? Clickable portfolio pictures, your own language for the projects, animations perhaps? You get the picture. Get as creative as possible!

  00