Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Mobile first accordion (Flexbox, SASS, JavaScript) - v2

sass/scss, lighthouse
Iva•120
@Ivuska
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi, I have updated the solution so only one item is opened and if user clicks the item twice, it is closed.

Any feedback is appreciated, thank you :)

========================================================================

Hi to everyone from Prague ;-)

I have finished my very first challenge using SASS and also a bit of JavaScript. I struggled very much with positioning of the images...

I would be grateful for tips:

  • how to position the images in the easier and more working way - especially in mobile version?
  • did I miss some useful feature from SASS that can be used in this challenge?
  • how to force to close the accordion item/line if another one is opened (so only one accordion item is opened)?

Thank you a lot and happy coding! :-)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Agustin•340
    @agusc01
    Posted over 3 years ago

    Hi Iva,

    Here's a tip for your third question

    • how to force to close the accordion item/line if another one is opened (so only one accordion item is opened)?

    The answer like your coding (with "for" and "this." selector)

    const accordion = document.getElementsByClassName('accordionItem');
    
    const closeAllItems = () => {
      for (i = 0; i < accordion.length; i++) {
        accordion[i].classList.remove('active');
      }
    };
    
    for (i = 0; i < accordion.length; i++) {
      accordion[i].addEventListener('click', function () {
        let wasItOpen = this.classList.contains('active');
        closeAllItems();
        if (wasItOpen === false) {
          this.classList.add('active');
        }
      });
    }
    

    And another way to writing code (which in my opinion is better, using foreach, so I didn't use "this." selector)

    
    const accordions = document.querySelectorAll('.accordionItem');
    
    const closeAllItems = () => {
      accordions.forEach((accordion) => {
        accordion.classList.remove('active');
      });
    };
    
    accordions.forEach((accordion) => {
      accordion.addEventListener('click', function () {
        let wasItOpen = accordion.classList.contains('active');
        closeAllItems();
        if (wasItOpen === false) {
          accordion.classList.add('active');
        }
      });
    });
    

    Keep coding and have fun !

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub