Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile First Approach using HTML CSS and JavaScript for validation

Ameya Deokule• 355

@ameyadeokule

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This my first mobile-first responsive website, I have tried using the principles to my fullest potential. Please provide feedback on my work I'll surely use those in my design. Thanks again for the time!!

Community feedback

maxigarrett• 20

@maxigarrett

Posted

está bueno, hay cosas por modificar para que sea mas eficiente como el js y el css. por ejemplo el css no se recomienda utilizar estilos descendientes como : .container form button(mas de dos clases no se recomienda y uttiiliza selectores de clases no de etiquetas).

el JS ya no se utiliza function ya se reemplazaron por arrow function porque al poner function se creea una funcion global y si llamas desde otro archivo una función con el mismo nombre te tira error.

function validateEmail(email) cámbialo por const validateEmail=(email)=> {}

son cosas que aprendí de grandes maestros saludos

0

Ameya Deokule• 355

@ameyadeokule

Posted

@maxigarrett Thanks for your feedback. I'll surely convert the email function to an arrow function and will stop using the nested selectors when not needed. I'll keep these things in mind when I code my next webpage.

0

@sumdude65

Posted

Great work! One thing get rid of the vertical scrollbar, overflow-y: hidden.

0

Ameya Deokule• 355

@ameyadeokule

Posted

Surely I'll get rid of the scrollbar. Appreciated your feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord