Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Mobile First Approach with css flex box.

Oishik Biswas•70
@pippal5536
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I tried to make the project without many lines of code but I am having a feeling that the project could be done with way lesser code. Please suggest me lesser code if there are any.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ebere Ndukwu•180
    @eby-coder
    Posted almost 3 years ago

    Congrats on completing this challenge. As for your question, I think one way of reducing the code and making it effective is to use the universal selector(*) instead of listing out all your html elements.

    html,
    body,
    div,
    span,
    applet,
    object,
    iframe,
    h1,
    h2,
    h3,
    h4,
    h5,
    h6,
    ...
    mark,
    audio,
    video {
        margin: 0;
        padding: 0;
        border: 0;
        font-size: 100%;
        font: inherit;
        vertical-align: baseline;
    }
    

    The universal selector selects any and all types of elements in an HTML page. It is useful when we want to select all the elements on the page. So, instead of this⬆️, you can use this⬇️

    *  {
        margin: 0;
        padding: 0;
        border: 0;
        font-size: 100%;
        font: inherit;
        vertical-align: baseline;
    }
    

    I hope this is helpful. Congrats once more on your solution.

    Marked as helpful
  • Ahmed•150
    @Ahmed-Elsayed-projects
    Posted almost 3 years ago

    Hello Oishik Biswas I've a few suggestion for you:

    1. Instead of mentioning every selector like html, body, div and etc. you could use the wildcard * which represents every single selector e.g
    * {
             /*code goes in here*/
    }
    
    1. when styling photos try to declare either height or width and not both(unless you are making it on purpose) to keep the photo's ratio correct. I think that you can already notice the difference between your QR image and design image
    2. Try use HTML headers(h1,h2, ...) for headings instead of paragraphs so you don't have to completely style <p> to look like a header. An example in your code:
          <p id="qr-tip">
            Improve your front-end skills by building projects
          </p>
    

    Hope it helps

    Marked as helpful
  • PhoenixDev22•16,830
    @PhoenixDev22
    Posted almost 3 years ago

    Hi Oishik Biswas,

    Congratulation on completing this challenge. Great job on this one. I have some suggestions regarding your solution if you don’t mind:

    • You should use <main> to wrap the card and <footer> for the attribution . HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
    • Page should contain one level heading. To tackle the accessibility issue in this challenge, you may use<h1> for id="qr-tip".
    • In my opinion, the alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor .
    • Adding rel="noopener" or rel="noreferrer" to target="_blank" links. When you link to a page on another site using target=”_blank” attribute, you can expose your site to performance and security issues.
    • Really important to keep css specificity as low/flat as possible. It’s not recommended to use the ids to target the DOM elements for styling purposes, better to use classes so that it could be more manageable and reusable.IDs have a much higher specificity than classes) IDs have many uses in a webpage aside from being a CSS selector. For example as page anchors, fragment identifiers or to link labels to form fields.

    Hopefully this feedback helps.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub