Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first Coming Soon Page - Base Apparel

@LizUK

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback would be appreciated.

Community feedback

@shubhamthedev

Posted

Hi @LizUK, nice job and you've nailed the line heights and font sizes pretty accurately and you've got the positioning done correctly. Here are some suggestions for you:

  • You should provide a label for your inputs since labels are used by the accessibility API for screen readers and other things.

  • If you're asking for the users email address then the input type should be email i.e. <input type="email"> and not text.

  • Plus you should use a form submit button or in other words the button element instead of an input element.

  • I don't know the reason but on my screen width the design has a horizontal scrollbar which should be there.

Hope this helps and keep coding 😃

1

@LizUK

Posted

@tomboynotes

Thanks alot for the advice. Ok, I will have a go at these revisions. Hopefully, today.

I really appreciate the feedback.

0

@LizUK

Posted

@tomboynotes I think I have dealt with the issues now. Thanks a lot for the advice.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord